Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: HTML escape crate version #69598

Merged
merged 1 commit into from
Mar 1, 2020
Merged

rustdoc: HTML escape crate version #69598

merged 1 commit into from
Mar 1, 2020

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Feb 29, 2020

As --crate-version accepts arbitrary strings they need to be escaped.

r? @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-02-29T23:48:30.7656068Z ========================== Starting Command Output ===========================
2020-02-29T23:48:30.7659052Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/52a7c53f-6511-4298-b3de-a811358cb2bc.sh
2020-02-29T23:48:30.7659337Z 
2020-02-29T23:48:30.7661946Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-29T23:48:30.7681862Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/69598/merge to s
2020-02-29T23:48:30.7685246Z Task         : Get sources
2020-02-29T23:48:30.7685461Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-29T23:48:30.7685707Z Version      : 1.0.0
2020-02-29T23:48:30.7685847Z Author       : Microsoft
---
2020-02-29T23:48:32.0279930Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-29T23:48:32.0290801Z ##[command]git config gc.auto 0
2020-02-29T23:48:32.0299163Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-29T23:48:32.0305561Z ##[command]git config --get-all http.proxy
2020-02-29T23:48:32.0318760Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/69598/merge:refs/remotes/pull/69598/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@ollie27
rustdoc: HTML escape crate version
3c97f8a 
As `--crate-version` accepts arbitrary strings they need to be escaped.
@ollie27 ollie27 force-pushed the rustdoc_crate-version_escape branch from 03406ec to 3c97f8a Compare March 1, 2020 00:15
@JohnTitor JohnTitor added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2020
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Mar 1, 2020

📌 Commit 3c97f8a has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 1, 2020
Merged
bors added a commit that referenced this pull request Mar 1, 2020
@bors
Auto merge of #69612 - Dylan-DPC:rollup-f180gcc, r=Dylan-DPC
beac68a 
Rollup of 7 pull requests

Successful merges:

 - #69504 (Use assert_ne in hash tests)
 - #69554 (Cleanup e0374)
 - #69568 (Clarify explanation of Vec<T> 'fn resize')
 - #69569 (simplify boolean expressions)
 - #69577 (Clean up E0375 explanation)
 - #69598 (rustdoc: HTML escape crate version)
 - #69607 (Clean up E0376 explanation)

Failed merges:

r? @ghost
@bors bors merged commit 22a0391 into rust-lang:master Mar 1, 2020
@ollie27 ollie27 deleted the rustdoc_crate-version_escape branch March 1, 2020 22:10
@jyn514 jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ollie27 @rust-highfive @GuillaumeGomez @bors @jyn514 @JohnTitor